Thread (10 messages) flat view 10 messages, 2 authors, 2012-12-11

Re: [net-next 1/7] bna: Code Cleanup and Enhancements

From: David Miller <davem@davemloft.net>
Date: 2012-12-10 22:13:56

From: Rasesh Mody <redacted>
Date: Mon, 10 Dec 2012 13:41:59 -0800
-		skb = unmap_array[unmap_cons].skb;
-		BUG_ON(!(skb));
-		unmap_array[unmap_cons].skb = NULL;
+		curr_ua = &unmap_array[unmap_cons];
+
+		skb = curr_ua->skb;
+		BUG_ON(!(skb));\
                               ^^^

Really?

Please carefully review your own work before submitting it for
inclusion.  When you have erroneous things like this in the
very first patch it reflects very poorly upon the quality of
your work.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help