Thread (37 messages) 37 messages, 4 authors, 2012-12-20

Re: [PATCH 00/17] ATM fixes for pppoatm/br2684

From: David Miller <davem@davemloft.net>
Date: 2012-12-02 01:47:58

From: David Woodhouse <dwmw2@infradead.org>
Date: Sun, 02 Dec 2012 00:35:47 +0000
On Sat, 2012-12-01 at 11:44 -0500, David Miller wrote:
quoted
quoted
drivers/atm/solos-pci.c: In function ‘solos_pci_init’:
drivers/atm/solos-pci.c:1329:2: error: size of unnamed array is
negative

It's from adding the completion to the solos skb cb, you can't do
that.  It won't fit on 64-bit when all debugging kconfig options are
enabled.
Thanks for catching that. I've just posted a [v2] version of the
offending patch, which no longer puts a completion into the skb cb.

I'd appreciate a slightly more clueful eye looking over the incremental
patch (below) just to confirm that the new method is correct, but it
certainly seems to work. This version is identical to the one I posted
earlier, except that I use dev_kfree_skb() in the pclose() function
instead of dev_kfree_skb_any(). We know this will be called from a
suitable context, and it even uses GFP_KERNEL a few lines higher up.

If that's OK, please pull the resulting tree from
	git://git.infradead.org/users/dwmw2/atm.git
Looks good, pulled, thanks David.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help