[PATCH 08/17] br2684: don't send frames on not-ready vcc
From: David Woodhouse <dwmw2@infradead.org>
Date: 2012-11-30 00:36:41
Subsystem:
atm, networking [general], the rest · Maintainers:
Chas Williams, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Avoid submitting packets to a vcc which is being closed. Things go badly wrong when the ->pop method gets later called after everything's been torn down. Signed-off-by: David Woodhouse <redacted> Acked-by: Krzysztof Mazur <redacted> --- net/atm/br2684.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index 8eb6fbe..c483021 100644
--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c@@ -249,6 +249,12 @@ static int br2684_xmit_vcc(struct sk_buff *skb, struct net_device *dev, skb_debug(skb); ATM_SKB(skb)->vcc = atmvcc = brvcc->atmvcc; + if (test_bit(ATM_VF_RELEASED, &atmvcc->flags) || + test_bit(ATM_VF_CLOSE, &atmvcc->flags) || + !test_bit(ATM_VF_READY, &atmvcc->flags)) { + dev_kfree_skb(skb); + return 0; + } pr_debug("atm_skb(%p)->vcc(%p)->dev(%p)\n", skb, atmvcc, atmvcc->dev); atomic_add(skb->truesize, &sk_atm(atmvcc)->sk_wmem_alloc); ATM_SKB(skb)->atm_options = atmvcc->atm_options;
--
1.8.0