Re: [patch] atm: forever loop loading ambassador firmware
From: chas williams - CONTRACTOR <hidden>
Date: 2012-11-28 15:41:59
Also in:
kernel-janitors
On Tue, 27 Nov 2012 20:29:35 +0300 Dan Carpenter [off-list ref] wrote:
There was a forever loop introduced here when we converted this to request_firmware() back in 2008. Signed-off-by: Dan Carpenter <redacted>
This certainly does seem to be the case. Acked-by: Chas Williams <redacted>
quoted hunk ↗ jump to hunk
--- Spotted in code reading. Untested.diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c index 89b30f3..ff7bb8a 100644 --- a/drivers/atm/ambassador.c +++ b/drivers/atm/ambassador.c@@ -1961,6 +1961,7 @@ static int __devinit ucode_init (loader_block * lb, amb_dev * dev) { res = loader_verify(lb, dev, rec); if (res) break; + rec = ihex_next_binrec(rec); } release_firmware(fw); if (!res) --To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html