Thread (3 messages) flat view 3 messages, 3 authors, 2012-11-28
STALE5015d

[patch] atm: forever loop loading ambassador firmware

From: Dan Carpenter <hidden>
Date: 2012-11-27 17:31:56
Also in: kernel-janitors
Subsystem: atm, the rest · Maintainers: Chas Williams, Linus Torvalds

There was a forever loop introduced here when we converted this to
request_firmware() back in 2008.

Signed-off-by: Dan Carpenter <redacted>
---
Spotted in code reading.  Untested.
diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index 89b30f3..ff7bb8a 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -1961,6 +1961,7 @@ static int __devinit ucode_init (loader_block * lb, amb_dev * dev) {
     res = loader_verify(lb, dev, rec);
     if (res)
       break;
+    rec = ihex_next_binrec(rec);
   }
   release_firmware(fw);
   if (!res)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help