Re: [PATCH] 8139cp: set ring address after enabling C+ mode

Jeff Garzik [off-list ref] :

On 11/21/2012 11:39 PM, David Miller wrote:

quoted

From: Jeff Garzik <redacted>
Date: Wed, 21 Nov 2012 22:47:39 -0500

quoted

State A:  pre-b01af457, known working
State B:  b01af457, known broken

State A is also known buggy on the largest consumer of this driver,
the emulated hardware.

quoted

Please evaluate this realistically.

If the simulator fails to match the hardware, that is a simulator bug.

Yes.

It is disappointing to work around someone else's software bug in
the kernel.

Yes. :o/

I like David Woodhouse's C (attached patch) since 1) Realtek does
not seem to care about oldies 2) the emulation will not be fixed in a
decent timeframe 3) real 8139cp users care.

It would be nice if gilboad could give it a try (users Cced).

Btw David W., could consider adding artificial delays between the writes
and see if / when things start to fail (CpCmd write in cp_start_hw is an
unflushed posted write for instance).

-- 
Ueimor