Re: [PATCH net-next 0/3] Enable PPS and PTP clocks automatically
From: David Miller <davem@davemloft.net>
Date: 2012-11-01 15:37:16
From: David Miller <davem@davemloft.net>
Date: 2012-11-01 15:37:16
From: Ben Hutchings <redacted> Date: Thu, 1 Nov 2012 01:29:57 +0000
There are a number of problems with PPS and PTP kconfig options: 1. PPS and PTP_1588_CLOCK depend on EXPERIMENTAL, therefore so must the clock drivers. (And EXPERIMENTAL is deprecated.) 2. PTP_1588_CLOCK depends on PPS, so users or clock driver options must explicitly select both. 3. In general, users have to enable too many options to get hardware timestamps and PTP working. 4. Boolean options for clock drivers combined with net drivers can force the PTP and PPS subsystems to be built-in unnecessarily. This series changes the options as follows: 1. Nothing depends on EXPERIMENTAL. 2. Only PTP_1588_CLOCK selects PPS. 3, 4. The boolean options are removed and the net driver options select PTP_1588_CLOCK. Where a net driver and associated clock driver are separate modules, the clock driver remains optional but is default y.
Looks good, series applied, thanks.