Re: [PATCH net-next 0/3] Enable PPS and PTP clocks automatically
From: Richard Cochran <richardcochran@gmail.com>
Date: 2012-11-01 08:19:35
Ben, I really like this idea, but I have a couple of questions, below. On Thu, Nov 01, 2012 at 01:29:57AM +0000, Ben Hutchings wrote:
Ben Hutchings (3): pps, ptp: Remove dependencies on EXPERIMENTAL
Kees Cook just posted a massive series to remove EXPERIMENTAL everywhere. Maybe it would make sense to have this series follow that one?
ptp: Make PTP_1588_CLOCK select rather than depend on PPS ptp: Enable clock drivers along with associated net/PHY drivers drivers/net/ethernet/intel/Kconfig | 28 +------------------ drivers/net/ethernet/intel/igb/Makefile | 4 +-- drivers/net/ethernet/intel/igb/igb.h | 6 ---- drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 - drivers/net/ethernet/intel/igb/igb_main.c | 28 --------------------
The #ifdefs in the Intel and PCH drivers are meant to streamline the code for users who are not interested in time stamping. Although the overhead of the additional is minimal (it really just a bunch of tests), and I wouldn't mind removing the conditionals, I suspect that some people won't like it.
drivers/net/ethernet/intel/ixgbe/Makefile | 3 +- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 6 ---- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 2 - drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 28 -------------------- drivers/net/ethernet/oki-semi/pch_gbe/Kconfig | 16 ----------- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe.h | 2 - .../net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 14 ----------
Thanks, Richard