[PATCH v3 0/4] make cadence ethernet drivers build on any architecture · Joachim Eastwood <hidden> · 2012-10-22
[PATCH v3 1/4] net/macb: fix truncate warnings · Joachim Eastwood <hidden> · 2012-10-22
[PATCH v3 1/4] net/macb: fix truncate warnings · David Laight <hidden> · 2012-10-23
[PATCH v3 1/4] net/macb: fix truncate warnings · davem@davemloft.net (David Miller) · 2012-10-23
[PATCH v3 1/4] net/macb: fix truncate warnings · Lothar Waßmann <hidden> · 2012-10-23
[PATCH v3 1/4] net/macb: fix truncate warnings · Joachim Eastwood <hidden> · 2012-10-23
[PATCH v3 2/4] net/cadence: get rid of HAVE_NET_MACB · Joachim Eastwood <hidden> · 2012-10-22
[PATCH v3 3/4] net/at91_ether: select MACB in Kconfig · Joachim Eastwood <hidden> · 2012-10-22
[PATCH v3 4/4] net/at91_ether: add pdata flag for reverse Eth addr · Joachim Eastwood <hidden> · 2012-10-22
[PATCH v3 0/4] make cadence ethernet drivers build on any architecture · davem@davemloft.net (David Miller) · 2012-10-23

STALE5042d

Revision v3 of 11 in this series.

Revisions (11)

2012-10-21 v1 [diff vs current]
2012-10-21 v1 [diff vs current]
2012-10-21 v1 [diff vs current]
2012-10-21 v2 [diff vs current]
2012-10-21 v1 [diff vs current]
2012-10-22 v1 [diff vs current]
2012-10-22 v1 [diff vs current]
2012-10-22 v3 [diff vs current]
2012-10-23 v3 [diff vs current]
2012-10-23 v3 current
2012-10-23 v3 [diff vs current]

Re: [PATCH v3 1/4] net/macb: fix truncate warnings

From: David Miller <davem@davemloft.net>
Date: 2012-10-23 08:48:29
Also in: linux-arm-kernel

From: "David Laight" <redacted>
Date: Tue, 23 Oct 2012 09:21:11 +0100

quoted

When building macb on x86_64 the following warnings show up:
  drivers/net/ethernet/cadence/macb.c: In function macb_interrupt:
  drivers/net/ethernet/cadence/macb.c:556:4: warning: large integer implicitly truncated to unsigned type [-Woverflow]

...

quoted

-			macb_writel(bp, IDR, ~0UL);
+			macb_writel(bp, IDR, -1);

Seems wrong to fix an error with an unsigned value
by using -1.

-1 is equally an unsigned value of all 1's and completely legitimate.
The correction being made here is one of size not signedness.