RE: [PATCH v3 1/4] net/macb: fix truncate warnings

From
David Laight <hidden>
Date
2012-10-23 08:21:11
Also in
linux-arm-kernel
Reply to
Joachim Eastwood, 2012-10-22
When building macb on x86_64 the following warnings show up:
  drivers/net/ethernet/cadence/macb.c: In function macb_interrupt:
  drivers/net/ethernet/cadence/macb.c:556:4: warning: large integer implicitly truncated to unsigned type [-Woverflow]
...
-			macb_writel(bp, IDR, ~0UL);
+			macb_writel(bp, IDR, -1);
Seems wrong to fix an error with an unsigned value
by using -1.

	David
Thread (10 messages) 10 messages, 4 authors, last reply 2012-10-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help