Thread (10 messages) flat view 10 messages, 4 authors, 2012-10-23
STALE5045d

Revision v3 of 11 in this series.

Revisions (11)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 [diff vs current]
  4. v2 [diff vs current]
  5. v1 [diff vs current]
  6. v1 [diff vs current]
  7. v1 [diff vs current]
  8. v3 [diff vs current]
  9. v3 current
  10. v3 [diff vs current]
  11. v3 [diff vs current]

RE: [PATCH v3 1/4] net/macb: fix truncate warnings

From: David Laight <hidden>
Date: 2012-10-23 08:21:11
Also in: linux-arm-kernel

When building macb on x86_64 the following warnings show up:
  drivers/net/ethernet/cadence/macb.c: In function macb_interrupt:
  drivers/net/ethernet/cadence/macb.c:556:4: warning: large integer implicitly truncated to unsigned type [-Woverflow]
...
-			macb_writel(bp, IDR, ~0UL);
+			macb_writel(bp, IDR, -1);
Seems wrong to fix an error with an unsigned value
by using -1.

	David
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help