Re: PROBLEM: Memory leak (at least with SLUB) from "secpath_dup" (xfrm) in 3.5+ kernels

On Mon, 2012-10-22 at 22:59 +0600, Mike Kazantsev wrote:

On Mon, 22 Oct 2012 17:28:02 +0200
Eric Dumazet [off-list ref] wrote:

quoted

On Mon, 2012-10-22 at 17:22 +0200, Eric Dumazet wrote:

quoted

On Mon, 2012-10-22 at 17:16 +0200, Eric Dumazet wrote:

quoted

OK, I believe I found the bug in IPv4 defrag / IPv6 reasm

Please test the following patch.

Thanks !

I'll send a more generic patch in a few minutes, changing
kfree_skb_partial() to call skb_release_head_state()

Here it is :

...

Problem is indeed gone in v3.7-rc2 with the proposed generic patch, I
haven't read the mail in time to test the first one, but I guess it's
not relevant now that the latter one works.

Thank you for taking your time to look into the problem and actually
fix it.

I'm unclear about policies in place on the matter, but I think this
patch might be a good candidate to backport into 3.5 and 3.6 kernels,
because they seem to suffer from the issue as well.

Thanks a lot Mike for your help.

Dont worry, I'll submit an official patch with details and all credits. 

David Miller will forward it to stable teams.

Thanks !