Re: PROBLEM: Memory leak (at least with SLUB) from "secpath_dup" (xfrm) in 3.5+ kernels
flat view
From: Eric Dumazet <hidden>
Date: 2012-10-22 08:15:48
Also in:
linux-mm
Subsystem:
networking [general], networking [ipsec], the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Steffen Klassert, Herbert Xu, Linus Torvalds
On Mon, 2012-10-22 at 04:58 +0600, Mike Kazantsev wrote:
I've grepped for "/org/free" specifically and sure enough, same scraps of data seem to be in some of the (varied) dumps there.
Content is not meaningful, as we dont initialize it. So you see previous content. Could you try the following :
diff --git a/net/core/dev.c b/net/core/dev.c
index 09cb3f6..a903cca 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c@@ -2977,6 +2977,9 @@ int netif_rx(struct sk_buff *skb) { int ret; +#ifdef CONFIG_XFRM + WARN_ON_ONCE(skb->sp); +#endif /* if netpoll wants it, pretend we never saw it */ if (netpoll_rx(skb)) return NET_RX_DROP;
@@ -3388,6 +3391,9 @@ out: */ int netif_receive_skb(struct sk_buff *skb) { +#ifdef CONFIG_XFRM + WARN_ON_ONCE(skb->sp); +#endif net_timestamp_check(netdev_tstamp_prequeue, skb); if (skb_defer_rx_timestamp(skb))
diff --git a/net/xfrm/xfrm_input.c b/net/xfrm/xfrm_input.c
index ab2bb42..5930e91 100644
--- a/net/xfrm/xfrm_input.c
+++ b/net/xfrm/xfrm_input.c@@ -29,11 +29,10 @@ struct sec_path *secpath_dup(struct sec_path *src) { struct sec_path *sp; - sp = kmem_cache_alloc(secpath_cachep, GFP_ATOMIC); + sp = kmem_cache_zalloc(secpath_cachep, GFP_ATOMIC); if (!sp) return NULL; - sp->len = 0; if (src) { int i; --
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>