Re: [PATCH v8 01/16] hashtable: introduce a small and naive hashtable
flat view
From: Tejun Heo <tj@kernel.org>
Date: 2012-10-30 21:43:07
Also in:
dm-devel, linux-mm, linux-nfs, lkml
Hello, Just some nitpicks. On Tue, Oct 30, 2012 at 02:45:57PM -0400, Sasha Levin wrote:
quoted hunk ↗ jump to hunk
+/* Use hash_32 when possible to allow for fast 32bit hashing in 64bit kernels. */ +#define hash_min(val, bits) \ +({ \ + sizeof(val) <= 4 ? \ + hash_32(val, bits) : \ + hash_long(val, bits); \ +})
Doesn't the above fit in 80 column. Why is it broken into multiple lines? Also, you probably want () around at least @val. In general, it's a good idea to add () around any macro argument to avoid nasty surprises. Looks good to me otherwise. Reviewed-by: Tejun Heo [off-list ref] Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>