Thread (4 messages) 4 messages, 2 authors, 2012-10-24

Re: [BUG] checkpatch.pl with commit 058806007450489bb8f457b275e5cb5c946320c1

flat view

From: Jeff Kirsher <hidden>
Date: 2012-10-24 21:01:16
Also in: lkml

On Wed, 2012-10-24 at 07:12 -0700, Joe Perches wrote:
On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote:
quoted
With the recent commit to checkpatch.pl:

commit 058806007450489bb8f457b275e5cb5c946320c1
Author: Joe Perches [off-list ref]
Date:   Thu Oct 4 17:13:35 2012 -0700

    checkpatch: check networking specific block comment style

We are seeing false positive warnings.  Here is an example of the
code the would generate a false warning:

#define foo	0x0000 /* foo comment */

checkpatch.pl generates a warnings that the */ should be on a separate
line, which in this case is incorrect.
Sorry 'bout that.  I believe it's fixed by:
https://lkml.org/lkml/2012/10/14/267
Yes, I confirm that the patch in the link you provided solves the issue
I was seeing.  Thanks, has the patch been accepted yet?  I see it is not
in Dave's NET tree as of yet.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help