From: Jeff Kirsher <hidden> Date: 2012-10-24 11:00:24
With the recent commit to checkpatch.pl:
commit 058806007450489bb8f457b275e5cb5c946320c1
Author: Joe Perches [off-list ref]
Date: Thu Oct 4 17:13:35 2012 -0700
checkpatch: check networking specific block comment style
We are seeing false positive warnings. Here is an example of the
code the would generate a false warning:
#define foo 0x0000 /* foo comment */
checkpatch.pl generates a warnings that the */ should be on a separate
line, which in this case is incorrect.
I apologize for not digging into the checkpatch.pl code to provide a
fix, I figure Joe (or anyone else with great checkpatch kung fu) can
figure out the issue and fix it faster than I could. :-)
Cheers,
Jeff
From: Joe Perches <joe@perches.com> Date: 2012-10-24 14:12:19
On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote:
With the recent commit to checkpatch.pl:
commit 058806007450489bb8f457b275e5cb5c946320c1
Author: Joe Perches [off-list ref]
Date: Thu Oct 4 17:13:35 2012 -0700
checkpatch: check networking specific block comment style
We are seeing false positive warnings. Here is an example of the
code the would generate a false warning:
#define foo 0x0000 /* foo comment */
checkpatch.pl generates a warnings that the */ should be on a separate
line, which in this case is incorrect.
From: Jeff Kirsher <hidden> Date: 2012-10-24 21:01:16
On Wed, 2012-10-24 at 07:12 -0700, Joe Perches wrote:
On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote:
quoted
With the recent commit to checkpatch.pl:
commit 058806007450489bb8f457b275e5cb5c946320c1
Author: Joe Perches [off-list ref]
Date: Thu Oct 4 17:13:35 2012 -0700
checkpatch: check networking specific block comment style
We are seeing false positive warnings. Here is an example of the
code the would generate a false warning:
#define foo 0x0000 /* foo comment */
checkpatch.pl generates a warnings that the */ should be on a separate
line, which in this case is incorrect.
Yes, I confirm that the patch in the link you provided solves the issue
I was seeing. Thanks, has the patch been accepted yet? I see it is not
in Dave's NET tree as of yet.
From: Joe Perches <joe@perches.com> Date: 2012-10-24 21:26:44
On Wed, 2012-10-24 at 13:51 -0700, Jeff Kirsher wrote:
On Wed, 2012-10-24 at 07:12 -0700, Joe Perches wrote:
quoted
On Wed, 2012-10-24 at 04:00 -0700, Jeff Kirsher wrote:
quoted
With the recent commit to checkpatch.pl:
commit 058806007450489bb8f457b275e5cb5c946320c1
Author: Joe Perches [off-list ref]
Date: Thu Oct 4 17:13:35 2012 -0700
checkpatch: check networking specific block comment style
We are seeing false positive warnings. Here is an example of the
code the would generate a false warning:
#define foo 0x0000 /* foo comment */
checkpatch.pl generates a warnings that the */ should be on a separate
line, which in this case is incorrect.
Yes, I confirm that the patch in the link you provided solves the issue
I was seeing. Thanks, has the patch been accepted yet? I see it is not
in Dave's NET tree as of yet.
Andrew Morton generally picks up my checkpatch twiddles.
It's in -next as of next-20121024.
commit db64ad0e6f55197bc3794bef007a25f2db4760fb