Re: [PATCH v2] net: calxedaxgmac: rework transmit ring handling

Eric Dumazet [off-list ref] wrote:

On Fri, 2012-10-12 at 13:04 -0500, Rob Herring wrote:

quoted

From: Rob Herring <redacted>

Only generate tx interrupts on every ring size / 4 descriptors. Move

the

quoted

netif_stop_queue call to the end of the xmit function rather than
checking at the beginning.

Signed-off-by: Rob Herring <redacted>
---
v2:
- Add missed enabling of the descriptor tx interrupt

Seems to be net-next material to me.

Perhaps, but the series as a whole is what I've been testing. This one has the least performance impact.

Furthermore, your changelog is a bit terse for such a patch, that could
easily break upper layers.

You need to tell us how long TX completion for a packet might be
deferred.

The prior behavior was only interrupting when done with all buffers.  It now will interrupt before completely emptying the ring.

Rob