Re: [PATCH v2] net: calxedaxgmac: rework transmit ring handling

On Fri, 2012-10-12 at 13:04 -0500, Rob Herring wrote:

From: Rob Herring <redacted>

Only generate tx interrupts on every ring size / 4 descriptors. Move the
netif_stop_queue call to the end of the xmit function rather than
checking at the beginning.

Signed-off-by: Rob Herring <redacted>
---
v2:
- Add missed enabling of the descriptor tx interrupt

Seems to be net-next material to me.

Furthermore, your changelog is a bit terse for such a patch, that could
easily break upper layers.

You need to tell us how long TX completion for a packet might be
deferred.

Thanks