Re: [PATCH net-next?] pktgen: Use simpler test for non-zero ipv6 address
flat view
From: Brian Haley <hidden>
Date: 2012-10-10 18:59:34
Also in:
lkml
On 10/10/2012 02:42 PM, Joe Perches wrote:
quoted hunk ↗ jump to hunk
Found by looking for if (foo) ; tests with a perl regex Yes Eric, it could be 2 compares instead of 4 on 64-bit systems with HAS_EFFICIENT_UNALIGNED_ACCESS. Maybe later or if there are other tests that could become something like ipv6_is_zeronet. cheers, Joe net/core/pktgen.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 148e73d..3aa8417 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c@@ -2422,11 +2422,10 @@ static void mod_cur_headers(struct pktgen_dev *pkt_dev) } } else { /* IPV6 * */ - if (pkt_dev->min_in6_daddr.s6_addr32[0] == 0 && - pkt_dev->min_in6_daddr.s6_addr32[1] == 0 && - pkt_dev->min_in6_daddr.s6_addr32[2] == 0 && - pkt_dev->min_in6_daddr.s6_addr32[3] == 0) ; - else { + if (pkt_dev->min_in6_daddr.s6_addr32[0] | + pkt_dev->min_in6_daddr.s6_addr32[1] | + pkt_dev->min_in6_daddr.s6_addr32[2] | + pkt_dev->min_in6_daddr.s6_addr32[3]) { int i;
Why not just use ipv6_addr_any() ? It has an HAS_EFFICIENT_UNALIGNED_ACCESS check too. -Brian