Re: [patch net] sky2: fix rx filter setup on link up

On Thu, 2012-10-04 at 00:40 -0700, Jiri Pirko wrote:

Tue, Sep 18, 2012 at 02:38:52AM CEST, mlindner@marvell.com wrote:

quoted

quoted

Mon, Sep 17, 2012 at 06:12:14PM CEST, shemminger@vyatta.com wrote:

quoted

On Mon, 17 Sep 2012 17:10:17 +0200
Jiri Pirko [off-list ref] wrote:

quoted

In my case I have following problem. sky2_set_multicast() sets registers
GM_MC_ADDR_H[1-4] correctly to:
0000 0800 0001 0410
However, when adapter gets link and sky2_link_up() is called, the values
are for some reason different:
0000 0800 0016 0410

Rather than papering over the problem, it would be better to
trace back what is setting those registers and fix that code.

quoted

Yes, I did that. No code at sky2.[ch] is writing to this registers other
than sky2_set_multicast() and sky2_gmac_reset() (I hooked on sky2_write*()).
So I strongly believe this is a HW issue (maybe only issue of my revision
"Yukon-2 EC chip revision 2")

I would like to check the registers as soon as I'm back in my office next week and report my findings.
Could you also please check the hint from Stephen?

Mirko, did you have a chance to look at this?

Sorry Jiri,

I was the last three weeks at a customer's office and not in our lab.
I'll check the issue this week.

Mirko