Re: [patch net] sky2: fix rx filter setup on link up

On Wed, 19 Sep 2012 22:38:25 +0200
Jiri Pirko [off-list ref] wrote:

You cannot call sky2_set_multicast() directly here. It is called from
__dev_set_rx_mode(). You would have to take at lease netif_addr_lock()
here. I think that clearer is to remember computed value....

Ugh, it would mean changing link_up to being done via workqueue.
But your code wasnt safe against changes to values from set_multicast race
either.