Re: [PATCH 11/11] net: xilinx: Show csum in bootlog
flat view
From: Ben Hutchings <hidden>
Date: 2012-10-05 13:36:59
Also in:
lkml
On Fri, 2012-10-05 at 07:48 +0200, Michal Simek wrote:
On 10/04/2012 09:15 PM, Ben Hutchings wrote:quoted
On Thu, 2012-10-04 at 20:14 +0200, Michal Simek wrote:quoted
Just show current setting in bootlog.[...]quoted
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c@@ -1052,12 +1052,14 @@ static int __devinit temac_of_probe(struct platform_device *op) /* Setup checksum offload, but default to off if not specified */ lp->temac_features = 0; p = (__be32 *)of_get_property(op->dev.of_node, "xlnx,txcsum", NULL); + dev_info(&op->dev, "TX_CSUM %d\n", be32_to_cpup(p)); if (p && be32_to_cpu(*p)) { lp->temac_features |= TEMAC_FEATURE_TX_CSUM; /* Can checksum TCP/UDP over IPv4. */ ndev->features |= NETIF_F_IP_CSUM; } p = (__be32 *)of_get_property(op->dev.of_node, "xlnx,rxcsum", NULL); + dev_info(&op->dev, "RX_CSUM %d\n", be32_to_cpup(p));[...] Is there any particular reason you think this needs to be logged by default, rather than letting users run ethtool -k? I suggest using dev_dbg() instead.The reason was just to show it in the bootlog. I will check ethtool support for these drivers.
'ethtool -k' should just work so long as the driver sets the right bits in ndev->features. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.