Re: [PATCH 11/11] net: xilinx: Show csum in bootlog
flat view
From: Michal Simek <monstr@monstr.eu>
Date: 2012-10-05 09:35:08
Also in:
lkml
On 10/04/2012 09:15 PM, Ben Hutchings wrote:
On Thu, 2012-10-04 at 20:14 +0200, Michal Simek wrote:quoted
Just show current setting in bootlog.[...]quoted
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c@@ -1052,12 +1052,14 @@ static int __devinit temac_of_probe(struct platform_device *op) /* Setup checksum offload, but default to off if not specified */ lp->temac_features = 0; p = (__be32 *)of_get_property(op->dev.of_node, "xlnx,txcsum", NULL); + dev_info(&op->dev, "TX_CSUM %d\n", be32_to_cpup(p)); if (p && be32_to_cpu(*p)) { lp->temac_features |= TEMAC_FEATURE_TX_CSUM; /* Can checksum TCP/UDP over IPv4. */ ndev->features |= NETIF_F_IP_CSUM; } p = (__be32 *)of_get_property(op->dev.of_node, "xlnx,rxcsum", NULL); + dev_info(&op->dev, "RX_CSUM %d\n", be32_to_cpup(p));[...] Is there any particular reason you think this needs to be logged by default, rather than letting users run ethtool -k? I suggest using dev_dbg() instead.
Ok. I have looked at it and there are missing some bits in ndev->features. Can you please check that my setting is correct? It is SG DMA ip/driver. ndev->features = NETIF_F_FRAGLIST | NETIF_F_SG With two options for csum on RX/TX. They can be selected independently. tx Partial csum over IPv4. -> NETIF_F_IP_CSUM tx Full csum. -> NETIF_F_HW_CSUM rx Full csum -> NETIF_F_RXCSUM Is there any option to support partial csum? Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian