Thread (4 messages) 4 messages, 4 authors, 2012-10-23

Re: [PATCH net-next 01/15] 6lowpan: lowpan_is_iid_16_bit_compressable() does not detect compressable address correctly

flat view

From: Tony Cheneau <hidden>
Date: 2012-10-23 14:58:24

Hello David,

Le 23.10.2012 08:49, David Miller a écrit :
[...]
It's really demoralizing to sit down to read a large 15 entry
patch series and this is the first thing I see:
quoted
 /*
- * check whether we can compress the IID to 16 bits,
- * it's possible for unicast adresses with first 49 bits are zero only.
- */
+* check whether we can compress the IID to 16 bits,
+* it's possible for unicast adresses with first 49 bits are zero only.
+*/
Don't break the comment indentation, it was perfectly fine.

I'm not reviewing the rest of the series, you'll need to repost
the entire thing after you fix this.

And if you're smart you'll make sure there aren't similar coding
style issues in the rest of your patches, else it's going to take
a long time to merge this crap into the tree.
Sorry about that, I failed to catch that mistake of mine (and several other ones that Jan spotted). I'll rework my patchset and resubmit. Thank you for pointing out this issue.

Regards,
Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help