Re: [PATCH net-next 01/15] 6lowpan: lowpan_is_iid_16_bit_compressable() does not detect compressable address correctly
flat view
From: David Miller <davem@davemloft.net>
Date: 2012-10-23 06:49:47
From: Tony Cheneau <redacted> Date: Tue, 23 Oct 2012 00:09:43 -0400
The current test is not RFC6282 compliant. The same issue has been found out and fixed in Contiki. This patch is basicaly a port of their fix. Signed-off-by: Tony Cheneau <redacted>
It's really demoralizing to sit down to read a large 15 entry patch series and this is the first thing I see:
quoted hunk ↗ jump to hunk
/* - * check whether we can compress the IID to 16 bits, - * it's possible for unicast adresses with first 49 bits are zero only. - */ +* check whether we can compress the IID to 16 bits, +* it's possible for unicast adresses with first 49 bits are zero only. +*/
Don't break the comment indentation, it was perfectly fine. I'm not reviewing the rest of the series, you'll need to repost the entire thing after you fix this. And if you're smart you'll make sure there aren't similar coding style issues in the rest of your patches, else it's going to take a long time to merge this crap into the tree.