Thread (8 messages) 8 messages, 4 authors, 2012-10-19

Re: [PATCH v1] net/core: support runtime PM on net_device

flat view

From: Ming Lei <hidden>
Date: 2012-10-19 01:45:06

On Fri, Oct 19, 2012 at 12:34 AM, Daniel Lezcano
[off-list ref] wrote:
Hi Ming,

IIUC, the pm_runtime is related to the device drivers, so at the first
glance, we should see invocation of the runtime's functions in drivers/*
and arch/*. Adding these calls in the net core, which makes sense at a
certain point, is a bit weird for me.

From my POV, if the drivers have been modified to support the pm_runtime
and this new functionality brought a regression with the ioctl, that
should be fixed in the drivers and not in the core code.

What happens with your patch if we use ethtool on a virtual device like
veth, macvlan, bridge, ... ?
No any effect no matter if these drivers implement runtime PM or not.


Thanks,
--
Ming Lei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help