Re: [PATCH v1] net/core: support runtime PM on net_device

On 10/18/2012 02:55 PM, Ming Lei wrote:

On Thu, Oct 18, 2012 at 7:40 PM, Bjørn Mork [off-list ref] wrote:

quoted

Because bugs are supposed to be fixed and not hidden?

OK, now let's discuss solution for the problem which should be
clear and be solved.

The 1st one is to do it by this patch, or rule out some ioctl cmd
which needn't wakeup device.

The second one is to fix ioctl one by one in each driver.

Any other solution?

quoted

Note that I am not claiming this is a bug.  That is still an open
question as far as I can see.

Hi Ming,

IIUC, the pm_runtime is related to the device drivers, so at the first
glance, we should see invocation of the runtime's functions in drivers/*
and arch/*. Adding these calls in the net core, which makes sense at a
certain point, is a bit weird for me.

From my POV, if the drivers have been modified to support the pm_runtime
and this new functionality brought a regression with the ioctl, that
should be fixed in the drivers and not in the core code.

What happens with your patch if we use ethtool on a virtual device like
veth, macvlan, bridge, ... ?

Shouldn't handle the mac address, mtu, ... changes with the rtnetlink also ?

Thanks
  -- Daniel

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog