[PATCH 04/10] net/macb: Fix a race in macb_start_xmit()
From: Nicolas Ferre <hidden>
Date: 2012-09-05 08:19:52
Also in:
linux-arm-kernel, lkml
Subsystem:
atmel macb ethernet driver, networking drivers, the rest · Maintainers:
Théo Lebrun, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
From: Havard Skinnemoen <redacted> Fix a race in macb_start_xmit() where we unconditionally set the TSTART bit. If an underrun just happened (we do this with interrupts disabled, so it might not have been handled yet), the controller starts transmitting from the first entry in the ring, which is usually wrong. Restart the controller after error handling. Signed-off-by: Havard Skinnemoen <redacted> [nicolas.ferre@atmel.com: split patch in topics] Signed-off-by: Nicolas Ferre <redacted> --- drivers/net/ethernet/cadence/macb.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 2228dfc..f4b8adf 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c@@ -390,6 +390,13 @@ static void macb_tx(struct macb *bp) dev_kfree_skb_irq(skb); } + /* + * Someone may have submitted a new frame while this interrupt + * was pending, or we may just have handled an error. + */ + if (head != tail && !(status & MACB_BIT(TGO))) + macb_writel(bp, NCR, macb_readl(bp, NCR) | MACB_BIT(TSTART)); + bp->tx_tail = tail; if (netif_queue_stopped(bp->dev) && TX_BUFFS_AVAIL(bp) > MACB_TX_WAKEUP_THRESH)
@@ -696,7 +703,18 @@ static int macb_start_xmit(struct sk_buff *skb, struct net_device *dev) skb_tx_timestamp(skb); - macb_writel(bp, NCR, macb_readl(bp, NCR) | MACB_BIT(TSTART)); + /* + * Only start the controller if the queue was empty; otherwise + * we may race against the hardware resetting the ring pointer + * due to a transmit error. + * + * If the controller is idle but the queue isn't empty, there + * must be a pending interrupt that will trigger as soon as we + * re-enable interrupts, and the interrupt handler will make + * sure the controler is started. + */ + if (NEXT_TX(bp->tx_tail) == bp->tx_head) + macb_writel(bp, NCR, macb_readl(bp, NCR) | MACB_BIT(TSTART)); if (TX_BUFFS_AVAIL(bp) < 1) netif_stop_queue(dev);
--
1.7.10