Thread (67 messages) 67 messages, 9 authors, 2012-09-06

Re: [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

From: Steven Rostedt <hidden>
Date: 2012-09-04 20:59:12
Also in: dm-devel, linux-mm, linux-nfs, lkml

On Tue, 2012-09-04 at 18:21 +0100, Pedro Alves wrote:
On 09/04/2012 06:17 PM, Steven Rostedt wrote:
quoted
On Tue, 2012-09-04 at 17:40 +0100, Pedro Alves wrote:
quoted
BTW, you can also go a step further and remove the need to close with double }},
with something like:

#define do_for_each_ftrace_rec(pg, rec)                                          \
        for (pg = ftrace_pages_start, rec = &pg->records[pg->index];             \
             pg && rec == &pg->records[pg->index];                               \
             pg = pg->next)                                                      \
          for (rec = pg->records; rec < &pg->records[pg->index]; rec++)
Yeah, but why bother? It's hidden in a macro, and the extra '{ }' shows
that this is something "special".
The point of both changes is that there's nothing special in the end
at all.  It all just works...
It would still fail on a 'break'. The 'while' macro tells us that it is
special, because in the end, it wont work.

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help