Re: [PATCH 1/5] ucc_geth: Reduce IRQ off in xmit path

Francois Romieu [off-list ref] wrote on 2012/09/19 00:39:38:

Joakim Tjernlund [off-list ref] :

quoted

Currently ucc_geth_start_xmit wraps IRQ off for the
whole body just to be safe.
Reduce the IRQ off period to a minimum.

The driver does not do much work in its irq handler. You may as well
convert it to the usual tg3-ish locking style (i.e. almost no locking).

You mean broadcom/tg3.c? It is a bit much to look at ATM for me and
there almost no locking with my patch also. Could possibly
be improved further but I am happy for now.

 Jocke