RE: [net PATCH v2 1/7] bnx2x: Avoid sending multiple statistics queries

-----Original Message-----
From: David Miller [mailto:davem@davemloft.net]
Sent: Thursday, September 13, 2012 11:17 PM
To: Yuval Mintz
Cc: netdev@vger.kernel.org; Dmitry Kravkov; Eilon Greenstein
Subject: Re: [net PATCH v2 1/7] bnx2x: Avoid sending multiple statistics queries

From: "Yuval Mintz" <redacted>
Date: Tue, 11 Sep 2012 17:34:08 +0300

quoted

From: Dmitry Kravkov <redacted>

During traffic when DCB is enabled, it is possible for multiple instances
of statistics queries to be sent to the chip - this may cause the FW to assert.

This patch prevents the sending of an additional instance of statistics query
while the previous query hasn't completed.

Signed-off-by: Dmitry Kravkov <redacted>
Signed-off-by: Yuval Mintz <redacted>
Signed-off-by: Eilon Greenstein <redacted>

This change results in no change in behavior as far as I can tell.

quoted

-	if (bnx2x_storm_stats_update(bp) && (bp->stats_pending++ == 3)) {
-		BNX2X_ERR("storm stats were not updated for 3 times\n");
-		bnx2x_panic();
+	if (bnx2x_storm_stats_update(bp)) {
+		if (bp->stats_pending++ == 3) {
+			BNX2X_ERR("storm stats were not updated for 3

times\n");

quoted

+			bnx2x_panic();
+		}

There is no difference between:

	if (A && B) {
		C;
	}

and:

	if (A) {
		if (B) {
			C;
		}
	}

Yet that's exactly what is happening in this patch.

And such a do-nothing change is certainly not appropriate this late in
the -rc series.

I'm tossing this entire series, please sort this out and submit
the real actual critical bug fixes.

return statement is not seen in the patch:
Before the change we returned from the function if (A &&B)
Now we return even if (A)