Thread (15 messages) 15 messages, 2 authors, 2012-09-11

[PATCH 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA

flat view
STALE5145d SUPERSEDED

From: Sony Chacko <hidden>
Date: 2012-09-11 01:37:21

Revision v1 of 13 in this series.

Revisions (13)
  1. v1
  2. v1
  3. v1
  4. v1
  5. v1
  6. v1 current
  7. v1
  8. v1
  9. v2 [diff vs current]
  10. v3 [diff vs current]
  11. v4 [diff vs current]
  12. v5 [diff vs current]
  13. v6 [diff vs current] 
From: Sony Chacko <redacted>

From: Ben Hutchings [mailto:bhutchings@solarflare.com]
Re: [PATCH 06/12] qlcnic: 83xx data path and HW interface routines
-static int load_fw_file;
+int load_fw_file;
module_param(load_fw_file, int, 0444); MODULE_PARM_DESC(load_fw_file, 
"Load firmware from (0=flash, 1=file");
All the variables being declared extern need to be renamed to have a 'qlcnic_' prefix.
(The parameters shouldn't be renamed, though - use module_param_named().)
quoted hunk
+int qlcnic_83xx_set_pauseparam(struct qlcnic_adapter *adapter,
+			       struct ethtool_pauseparam *pause) {
+	int status = 0;
+	u32 config = adapter->ahw->port_config;
+
+	if ((pause->rx_pause) || (pause->tx_pause) || (pause->autoneg))
+		adapter->ahw->port_config |= QLC_83XX_CFG_PAUSE_STD;
+	else if (!(pause->rx_pause && pause->tx_pause && pause->autoneg))
Since you appear to support only all-enabled or all-disabled,
this second condition should be:
!pause->rx_pause && !pause->tx_pause && !pause->autoneg
We have updated the patches.
Please apply the updated 12 patch series to net-next.

Thanks,
Sony
  



    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help