Thread (16 messages) 16 messages, 2 authors, 2012-09-06

[PATCH 0/12] qlcnic: patches for new adapter - Qlogic 83XX CNA

flat view
STALE5148d SUPERSEDED

From: Sony Chacko <hidden>
Date: 2012-09-06 06:39:17

Revision v1 of 13 in this series.

Revisions (13)
  1. v1
  2. v1
  3. v1
  4. v1 current
  5. v1
  6. v1
  7. v1
  8. v1
  9. v2 [diff vs current]
  10. v3 [diff vs current]
  11. v4 [diff vs current]
  12. v5 [diff vs current]
  13. v6 [diff vs current] 
From: Sony Chacko <redacted>

From: David Miller [mailto:davem@davemloft.net]
From: David Miller [mailto:davem@davemloft.net] 
Sent: Friday, August 31, 2012 1:05 PM
quoted hunk
+static inline int
+qlcnic_config_led(struct qlcnic_adapter *adapter, u32 state, u32 
+rate) {
+	return adapter->nic_ops->config_led(adapter, state, rate);
+
+}
+
Please get rid of those unnecessary empty lines in the function bodies.
From: David Miller <davem@davemloft.net>
Date: Fri, 31 Aug 2012 20:00:35 -0400 (EDT)
Also in patch #5:
-	qlcnic_config_ipaddr(adapter, ifa->ifa_address, QLCNIC_IP_UP);
+	qlcnic_config_ipaddr(adapter, ifa->ifa_address,
+						 QLCNIC_IP_UP);
This is not the correct way to format multi-line function calls,
the correct way is:
qlcnic_config_ipaddr(adapter, ifa->ifa_address,
		     QLCNIC_IP_UP);
I have made the changes as you suggested above.
Please apply the updated 12 patch series to net-next.

Thanks,
Sony
  



    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help