[PATCH 2/5] de2104x: Call netif_carrier_off() after register_netdev()
From: Ilya Shchepetkov <hidden>
Date: 2012-08-14 10:29:36
Also in:
lkml
Subsystem:
networking drivers, the rest, tulip network drivers · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
For carrier detection to work properly when binding the driver with a cable unplugged, netif_carrier_off() should be called after register_netdev(), not before. Calling netif_carrier_off() before register_netdev() was causing the network interface to miss a linkwatch pending event leading to an inconsistent state if the link is not up when interface is initialized. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Ilya Shchepetkov <redacted> --- drivers/net/ethernet/dec/tulip/de2104x.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c
index 61cc093..237f254 100644
--- a/drivers/net/ethernet/dec/tulip/de2104x.c
+++ b/drivers/net/ethernet/dec/tulip/de2104x.c@@ -2005,8 +2005,6 @@ static int __devinit de_init_one (struct pci_dev *pdev, de->media_timer.function = de21041_media_timer; de->media_timer.data = (unsigned long) de; - netif_carrier_off(dev); - /* wake up device, assign resources */ rc = pci_enable_device(pdev); if (rc)
@@ -2074,6 +2072,9 @@ static int __devinit de_init_one (struct pci_dev *pdev, rc = register_netdev(dev); if (rc) goto err_out_iomap; + + /* turn off carrier */ + netif_carrier_off(dev); /* print info about board and interface just registered */ netdev_info(dev, "%s at %p, %pM, IRQ %d\n",
--
1.7.7