Re: [RFC v2 1/7] hashtable: introduce a small and naive hashtable

On 08/04/2012 12:23 AM, Tejun Heo wrote:

Hello,

On Sat, Aug 04, 2012 at 12:20:02AM +0200, Sasha Levin wrote:

quoted

On 08/03/2012 11:48 PM, Tejun Heo wrote:

quoted

On Fri, Aug 03, 2012 at 11:41:34PM +0200, Sasha Levin wrote:

quoted

I forgot to comment on that one, sorry.

If we put hash entries after struct hash_table we don't take the
bits field size into account, or did I miss something?

So, if you do the following,

	struct {
		struct {
			int i;
			long ar[];
		} B;
		long __ar_storage[32];
	} A;

struct A should have been an union, right?

I actually meant an enclosing struct.  When you're defining a struct
member, simply putting the storage after a struct with var array
should be good enough.  If that doesn't work, quite a few things in
the kernel will break.

Ah, I see, I've missed that part.

Thanks!

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>