Thread (33 messages) flat view 33 messages, 6 authors, 2012-08-05

Re: [RFC v2 1/7] hashtable: introduce a small and naive hashtable

From: Tejun Heo <tj@kernel.org>
Date: 2012-08-03 21:48:14
Also in: linux-mm, lkml

Hello,

On Fri, Aug 03, 2012 at 11:41:34PM +0200, Sasha Levin wrote:
I forgot to comment on that one, sorry.

If we put hash entries after struct hash_table we don't take the
bits field size into account, or did I miss something?
So, if you do the following,

	struct {
		struct {
			int i;
			long ar[];
		} B;
		long __ar_storage[32];
	} A;

It should always be safe to dereference A.B.ar[31].  I'm not sure
whether this is something guaranteed by C tho.  Maybe compilers are
allowed to put members in reverse order but I think we already depend
on the above.

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help