Thread (67 messages) flat view 67 messages, 11 authors, 2012-08-29

Re: [PATCH V2 1/2] ipvs: IPv6 MTU checking cleanup and bugfix

From: Patrick McHardy <hidden>
Date: 2012-08-28 20:08:57
Also in: lvs-devel, netfilter-devel

On Tue, 28 Aug 2012, Jesper Dangaard Brouer wrote:
Cleaning up the IPv6 MTU checking in the IPVS xmit code, by using
a common helper function __mtu_check_toobig_v6().

The MTU check for tunnel mode can also use this helper as
ntohs(old_iph->payload_len) + sizeof(struct ipv6hdr) is qual to
skb->len.  And the 'mtu' variable have been adjusted before
calling helper.

Notice, this also fixes a bug, as the the MTU check in ip_vs_dr_xmit_v6()
were missing a check for skb_is_gso().

This bug e.g. caused issues for KVM IPVS setups, where different
Segmentation Offloading techniques are utilized, between guests,
via the virtio driver.  This resulted in very bad performance,
due to the ICMPv6 "too big" messages didn't affect the sender.

Signed-off-by: Jesper Dangaard Brouer <redacted>
Applied to my nf-nat-ipv6 tree.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help