Thread (45 messages) 45 messages, 6 authors, 2012-08-30

Re: [RFC PATCH bridge 4/5] bridge: Add private ioctls to configure vlans on bridge ports

From: Stephen Hemminger <hidden>
Date: 2012-08-24 18:11:32

On Fri, 24 Aug 2012 10:56:16 -0700
"Paul E. McKenney" [off-list ref] wrote:
quoted
+			return -EPERM;
+
+		rcu_read_lock();
+		if ((p = br_get_port(br, args[1])) == NULL) {
+			rcu_read_unlock();
+			return -EINVAL;
+		}
+		rcu_read_unlock();  
Why is it safe to pass "p" out of the RCU read-side critical section?
I don't see that br_get_port() does anything to make this safe, at least
not in v3.5.
It would be accidentally protected by rtnl?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help