Re: [PATCH net-next] sctp: fix compile issue with disabled CONFIG_NET_NS

On Thu, 2012-08-16 at 11:58 -0700, Eric W. Biederman wrote:

Ulrich Weber [off-list ref] writes:

quoted

struct seq_net_private has no struct net
if CONFIG_NET_NS is not enabled

My mistake.

Reviewed-by: "Eric W. Biederman" <redacted>

quoted

Signed-off-by: Ulrich Weber <redacted>

Ulrich do you get any performance advantage by disabling the network
namespace?

I am wondering if there is any benefit to keeping it possible to disable
the network namespace?

The original reason for the option was so that distributions and
other who wanted to avoid new code could protect their users, and
that reasons seems to have long since passed.

[...]

Network namespaces are now used by common applications such as Chrome/
Chromium and vsftpd (which flushed out some of the early implementation
problems).  They undoubtedly have some overhead that some users would
like to avoid, but I wouldn't expect distributions to disable the
option.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.