Thread (19 messages) 19 messages, 4 authors, 2012-08-04

Re: [PATCH 1/2] net: Allow to create links with given ifindex

From: David Miller <davem@davemloft.net>
Date: 2012-08-04 08:25:45

From: Eric Dumazet <redacted>
Date: Sat, 04 Aug 2012 09:10:40 +0200
On Fri, 2012-08-03 at 16:56 -0700, David Miller wrote:
quoted
From: Eric Dumazet <redacted>
Date: Fri, 03 Aug 2012 07:45:29 +0200
quoted
@@ -1587,13 +1587,11 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
 	if (ipv4_is_zeronet(daddr))
 		goto martian_destination;
 
-	if (likely(!IN_DEV_ROUTE_LOCALNET(in_dev))) {
-		if (ipv4_is_loopback(daddr))
-			goto martian_destination;
+	if (ipv4_is_loopback(daddr) && !IN_DEV_NET_ROUTE_LOCALNET(in_dev, net))
+		goto martian_destination;
 
-		if (ipv4_is_loopback(saddr))
-			goto martian_source;
-	}
+	if (ipv4_is_loopback(saddr) && !IN_DEV_NET_ROUTE_LOCALNET(in_dev, net))
+		goto martian_source;
Maybe clearer as:

	if ((ipv4_is_loopback(daddr) || ipv4_is_loopback(saddr)) &&
	    !IN_DEV_NET_ROUTE_LOCALNET(in_dev, net))
		goto martian_source;
Clearer, but handling of a martian destination is different of the
martian source ;)
Duh, I missed that, too many martians :-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help