Re: [PATCH 1/2] net: Allow to create links with given ifindex
From: David Miller <davem@davemloft.net>
Date: 2012-08-03 23:56:12
From: Eric Dumazet <redacted> Date: Fri, 03 Aug 2012 07:45:29 +0200
quoted hunk ↗ jump to hunk
@@ -1587,13 +1587,11 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr, if (ipv4_is_zeronet(daddr)) goto martian_destination; - if (likely(!IN_DEV_ROUTE_LOCALNET(in_dev))) { - if (ipv4_is_loopback(daddr)) - goto martian_destination; + if (ipv4_is_loopback(daddr) && !IN_DEV_NET_ROUTE_LOCALNET(in_dev, net)) + goto martian_destination; - if (ipv4_is_loopback(saddr)) - goto martian_source; - } + if (ipv4_is_loopback(saddr) && !IN_DEV_NET_ROUTE_LOCALNET(in_dev, net)) + goto martian_source;
Maybe clearer as: if ((ipv4_is_loopback(daddr) || ipv4_is_loopback(saddr)) && !IN_DEV_NET_ROUTE_LOCALNET(in_dev, net)) goto martian_source;