Thread (8 messages) flat view 8 messages, 3 authors, 2012-08-03

Re: [PATCH] ipv4: remove parentheses in return statement

From: David Miller <davem@davemloft.net>
Date: 2012-08-03 21:31:36

From: Jean Sacren <redacted>
Date: Fri, 3 Aug 2012 14:23:50 -0600
To illustrate, the patch merely changes

	return (A);

to

	return A;
Life is not black and white my friend, there are shades
of gray.  I feel bad for you if you read coding style rules
in a %100 literal sense with no room for interpretation.

People add extra parenthesis to add clarity, so you are
entirely misrepresenting these cases.

This was not a simple case of:

	return (A);

but more like something that looks as:

	return ((A & B) | (C ^ D));

and that is perfectly fine.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help