Thread (8 messages) flat view 8 messages, 3 authors, 2012-08-03

Re: [PATCH] ipv4: remove parentheses in return statement

From: David Miller <davem@davemloft.net>
Date: 2012-08-03 08:52:44

From: Jean Sacren <redacted>
Date: Fri,  3 Aug 2012 01:43:10 -0600
It is always wrong to write 'return (...)'.
In your imagination.
After removal, realign the code where necessary.

Signed-off-by: Jean Sacren <redacted>
-	return ((val ^ (val >> 8) ^ (val >> 16) ^ (val >> 24)) &
-		(IN4_ADDR_HSIZE - 1));
+	return (val ^ (val >> 8) ^ (val >> 16) ^ (val >> 24)) &
+	       (IN4_ADDR_HSIZE - 1);
Those parenthesis are there to make the evaluation order and
grouping explicit.

The other ones you changed are wrong for similar reasons.

I absolutely am not applying patches like this.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help