Mon, Jul 30, 2012 at 08:19:11PM CEST, jon.mason@intel.com wrote:

On Mon, Jul 30, 2012 at 04:02:16PM +0200, Jiri Pirko wrote:

quoted

Mon, Jul 30, 2012 at 02:26:34AM CEST, jon.mason@intel.com wrote:

quoted

+static int __devinit ntb_netdev_probe(struct pci_dev *pdev)
+{
+	struct net_device *ndev;
+	struct ntb_netdev *dev;
+	int rc;
+
+	ndev = alloc_etherdev(sizeof(struct ntb_netdev));
+	if (!ndev)
+		return -ENOMEM;
+
+	dev = netdev_priv(ndev);
+	dev->ndev = ndev;
+	dev->pdev = pdev;
+	BUG_ON(!dev->pdev);
+	ndev->features = NETIF_F_HIGHDMA;
+
+	//ndev->priv_flags |= IFF_LIVE_ADDR_CHANGE;

	^^ I guess you forgot to un-comment this.

Oops.  An easy fix.  Anything else?

The rest looks good to me.

Thanks,
Jon