Thread (26 messages) 26 messages, 7 authors, 2012-08-02

Re: [RFC v2 2/2] net: Add support for NTB virtual ethernet device

From: Jon Mason <hidden>
Date: 2012-07-30 18:19:13
Also in: linux-pci, lkml

On Mon, Jul 30, 2012 at 04:02:16PM +0200, Jiri Pirko wrote:
Mon, Jul 30, 2012 at 02:26:34AM CEST, jon.mason@intel.com wrote:
quoted
+static int __devinit ntb_netdev_probe(struct pci_dev *pdev)
+{
+	struct net_device *ndev;
+	struct ntb_netdev *dev;
+	int rc;
+
+	ndev = alloc_etherdev(sizeof(struct ntb_netdev));
+	if (!ndev)
+		return -ENOMEM;
+
+	dev = netdev_priv(ndev);
+	dev->ndev = ndev;
+	dev->pdev = pdev;
+	BUG_ON(!dev->pdev);
+	ndev->features = NETIF_F_HIGHDMA;
+
+	//ndev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
	^^ I guess you forgot to un-comment this.
Oops.  An easy fix.  Anything else?

Thanks,
Jon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help