Re: [PATCH] mlx4: Add support for EEH error recovery
From: Or Gerlitz <hidden>
Date: 2012-07-23 21:42:09
On Tue, Jul 24, 2012 at 12:34 AM, David Miller [off-list ref] wrote:
Can we please move forward, if he implemented the feature properly and he tested it successfully, unless you can find a logic or stylistic flaw in his patch please ACK it. You can't hold his changes back while you work out how _YOU_ can test it to your liking.
Hi Dave, We're trying to act in R/R (Responsive and Responsible) manner - namely Shlomo did code review of the patches and we want to further evaluate them by testing, I think its fully legitimate to test a patch before ACK-ing. Doing these types of tests isn't around my personal typical daily menu and I'm asking for some directives from the author on how to issue that testing, I don't see what wrong here. We're planning anyway to go deeper around this area and enhance the PCI hotplug /error handling related code in the driver, so there's an initial learing curve here, makes sense? we can move the Q&A for the testing to be off-list if you prefer it to go that way. Or.