Re: [RFC] r8169 : why SG / TX checksum are default disabled

From: Eric Dumazet <redacted>
Date: Thu, 19 Jul 2012 00:05:36 +0200

On Wed, 2012-07-18 at 23:44 +0200, Francois Romieu wrote:

quoted

David Miller [off-list ref] :
[...]

quoted

A NETDEV_TX_OK return means we accepted the SKB, it doesn't look like
that's what you are doing in the skb_padto() failure path.

?

- skb_padto fails
  (original skb is implicitely freed)
- skb_padto returns error status (!= 0)
- rtl8169_tso_csum returns false
- start_xmit returns NETDEV_TX_OK. 

I'll search the missing "!" after some sleep if that's what you are talking
about. Otherwise than that, I don't get it.

Yes, I believe your patch is fine.

In fact many drivers dont account the error in their stats.

My bad, I forgot that skb_padto() frees the SKB on failure.