Thread (20 messages) flat view 20 messages, 4 authors, 2012-07-25

Re: [RFC] r8169 : why SG / TX checksum are default disabled

From: Francois Romieu <romieu@fr.zoreil.com>
Date: 2012-07-18 21:57:09

David Miller [off-list ref] :
[...]
A NETDEV_TX_OK return means we accepted the SKB, it doesn't look like
that's what you are doing in the skb_padto() failure path.
?

- skb_padto fails
  (original skb is implicitely freed)
- skb_padto returns error status (!= 0)
- rtl8169_tso_csum returns false
- start_xmit returns NETDEV_TX_OK. 

I'll search the missing "!" after some sleep if that's what you are talking
about. Otherwise than that, I don't get it.

-- 
Ueimor
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help