Re: [PATCH 02/11] enic: remove unnecessary setting of skb->dev
From: Jon Mason <jdmason@kudzu.us>
Date: 2012-07-12 21:19:18
On Mon, Jul 9, 2012 at 5:09 PM, Jon Mason [off-list ref] wrote:
skb->dev is being unnecessarily set after calling eth_type_trans. eth_type_trans already sets skb->dev to the proper value, thus making this unnecessary. Signed-off-by: Jon Mason <jdmason@kudzu.us> Cc: Christian Benvenuti <redacted> Cc: Roopa Prabhu <redacted>
This address bounced. Anyone know of an updated address for Roopa or should they be removed from the MAINTAINERS list?
quoted hunk ↗ jump to hunk
Cc: Neel Patel <redacted> Cc: Nishank Trivedi <redacted> --- drivers/net/ethernet/cisco/enic/enic_main.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c index 8132c78..ad1468b 100644 --- a/drivers/net/ethernet/cisco/enic/enic_main.c +++ b/drivers/net/ethernet/cisco/enic/enic_main.c@@ -1300,8 +1300,6 @@ static void enic_rq_indicate_buf(struct vnic_rq *rq, skb->ip_summed = CHECKSUM_COMPLETE; } - skb->dev = netdev; - if (vlan_stripped) __vlan_hwaccel_put_tag(skb, vlan_tci); --1.7.9.5