Re: [PATCH net-next 06/10] {NET,IB}/mlx4: Add device managed flow steering firmware API
From: Or Gerlitz <hidden>
Date: 2012-07-01 12:30:08
On 7/1/2012 1:30 PM, David Miller wrote: [...]
quoted hunk ↗ jump to hunk
@@ -136,6 +138,11 @@ module_param_array(port_type_array, int, &arr_argc, 0444); MODULE_PARM_DESC(port_type_array, "Array of port types: HW_DEFAULT (0) is default " "1 for IB, 2 for Ethernet"); +static int mlx4_flow_steering_hash; +module_param_named(flow_steering_hash, mlx4_flow_steering_hash, int, 0444); +MODULE_PARM_DESC(flow_steering_hash, + "Flow steering hash function configuration. Config options: L2 = 0, L2_L3_L4 = 1 (default: L2)."); +No module paramters, do it via ethtool or similar.
Dave, We'll be handling the indentation, comments and other syntax issues you have pointed out and submit V1, hopefully which would be clean from such errors. Re the usage of the module param - as was pointed out in the change-log, please note that this policy is **global** to the HCA, that is effects all the Ethernet (and down the road, also IPoIB flow-steering, when we run a card with one IB port and one Eth port) net-devices that relate to that device. The module param is for mlx4_core and not for mlx4_en. In that respect, per net-device ethtool directive wouldn't work, even when there is a dedicated firmware command that allows changing this in run-time, which we don't have now. My thinking was that once we have this command at hand, we can add sysfs/etc entry at the mlx4_core level to provide a different hash function to the device. And for the time being use the module param, makes sense? Or.