Re: [PATCH net-next 04/10] net/mlx4: Set steering mode according to device capabilities

From: Or Gerlitz <redacted>
Date: Sun,  1 Jul 2012 12:43:37 +0300

+				/* Add the default qp number as multicast
+				* promisc */

This is not the correct way to format a comment, do it:

	/* Like
	 * this.
	 */

+	if (dev->caps.flags & MLX4_DEV_CAP_FLAG_VEP_UC_STEER &&
+	    dev->caps.flags & MLX4_DEV_CAP_FLAG_VEP_MC_STEER) {
+		dev->caps.steering_mode = MLX4_STEERING_MODE_B0;
+
+	} else {

That empty line is extraneous and ugly, remove it.

+/* Driver supports 2 diffrent device methods to manage traffic steering:
+	- B0 steering mode - Common low level API for ib and (if supported) eth.
+	- A0 steering mode - Limited low level API for eth. In case of IB,
+			     B0 mode is in use.
+ */

Improperly formatted, do it like this:

/* Driver supports 2 diffrent device methods to manage traffic steering:
 *	- B0 steering mode - Common low level API for ib and (if supported) eth.
 *	- A0 steering mode - Limited low level API for eth. In case of IB,
 *			     B0 mode is in use.
 */